[BAZEL] Update the Bazel overlay to use MODULE #4398
Conversation
|
Hi, @sjain-stanford the wiki listed you as the maintainer for the bazel build. Could you review this PR? Thanks. |
| llvm_config.with_system_environment(["HOME", "INCLUDE", "LIB", "TMP", "TEMP"]) | ||
|
|
||
| # llvm_config.use_default_substitutions() | ||
| llvm_config.use_default_substitutions() |
There was a problem hiding this comment.
for FileCheck substitution using @LLVM_TOOLS_DIR@
Thanks for the ping. I am no longer overseeing the bazel build for torch-mlir but let me loop in someone who can help. |
|
I don't have time to take over the maintenance of bazel build files for this. |
|
@matthewfl does Cruise need the bazel build going forward? If so, can you re-assign to who needs to review it to make sure the changes are compatible with Cruise's downstream? This was mainly added (and is expected to be supported) by Cruise but neither Ahmed nor I are with Cruise anymore so we need the right maintainers for it going forward. |
|
@sjain-stanford bazel is still needed going forward. If there is an issue with bazel then we will have to maintain an internal patch. I don't think that we should be holding up @shantanu-gontia's PR. We will eventually be upgrading bazel and switching to modules, but I don't have a timeline for that. |
|
Thanks @sjain-stanford, @matthewfl @matthewfl Would you be able to review this PR? Or do you know who would be able to? Since this is my first PR in this project, I don't have access. Thanks. |
3 participants
WORKSPACE are deprecated and to be replaced by MODULE. Bazel roadmap mentions WORKSPACE are going to be removed entirely. Mainline LLVM has also upgraded from WORKSPACE to MODULE.
This PR updates the Torch-MLIR overlay to use MODULE and fixes the bazel build.
.bazelversionto 8.4.0 (parity with mainline LLVM)AArch64target to the LLVM Build (to support local builds on Arm)